Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use primary error as context of NoWitnessLeft error #477

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jul 24, 2020

So user can see the real error for verification failure.

// Swap primary, and continue with new primary, if there is any witness left.
self.peers.replace_faulty_primary()?;
self.peers.replace_faulty_primary(Some(err))?;
Copy link
Member

@liamsi liamsi Jul 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When putting together the light-node, I also stumbled upon this: I was seeing "no witness left" in the log and it wasn't really informing what went wrong.
@romac does anything speak against this approach? The todo is indicating you already had sth in mind for this?

Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@liamsi liamsi merged commit cf4a28d into informalsystems:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants